s390/startup: correct "dfltcc" option parsing
authorVasily Gorbik <gor@linux.ibm.com>
Fri, 25 Sep 2020 20:42:30 +0000 (22:42 +0200)
committerVasily Gorbik <gor@linux.ibm.com>
Wed, 30 Sep 2020 10:09:54 +0000 (12:09 +0200)
Currently if just "dfltcc" is passed as a kernel command line option
"val" going to be NULL, this leads to reading at address 0 in
strcmp(val, "off")

Fix that by making sure "val" is not NULL. This does not affect option
handling logic.

Reviewed-by: Sven Schnelle <svens@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
arch/s390/boot/ipl_parm.c

index 92ebc4a58fe2d138ee2a876d2215124d4e3cfa03..1add096e09a62e49e08959cecde9065bf37195aa 100644 (file)
@@ -230,7 +230,7 @@ void parse_boot_command_line(void)
                if (!strcmp(param, "vmalloc") && val)
                        vmalloc_size = round_up(memparse(val, NULL), PAGE_SIZE);
 
-               if (!strcmp(param, "dfltcc")) {
+               if (!strcmp(param, "dfltcc") && val) {
                        if (!strcmp(val, "off"))
                                zlib_dfltcc_support = ZLIB_DFLTCC_DISABLED;
                        else if (!strcmp(val, "on"))