2011-02-26 Michael Snyder <msnyder@vmware.com>

	* breakpoint.c (reattach_breakpoints): Avoid resource leak (ui_file).

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 95e92d0..1ae76bd 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,7 @@
 2011-02-26  Michael Snyder  <msnyder@vmware.com>
 
+       * breakpoint.c (reattach_breakpoints): Avoid resource leak (ui_file).
+
        * maint.c (maintenance_do_deprecate): Plug a memory leak.
 
        * dwarf2loc.c (insert_bits): Avoid shadowing a function param

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 484a831..490084e 100644 (file)
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -1989,7 +1989,7 @@ reattach_breakpoints (int pid)
   struct cleanup *old_chain;
   struct bp_location *bl, **blp_tmp;
   int val;
-  struct ui_file *tmp_error_stream = mem_fileopen ();
+  struct ui_file *tmp_error_stream;
   int dummy1 = 0, dummy2 = 0;
   struct inferior *inf;
   struct thread_info *tp;
@@ -2003,6 +2003,7 @@ reattach_breakpoints (int pid)
 
   inferior_ptid = tp->ptid;
 
+  tmp_error_stream = mem_fileopen ();
   make_cleanup_ui_file_delete (tmp_error_stream);
 
   ALL_BP_LOCATIONS (bl, blp_tmp)