media: vim2m: the v4l2_m2m_buf_copy_data args were swapped
authorHans Verkuil <hverkuil@xs4all.nl>
Fri, 11 Jan 2019 11:43:12 +0000 (06:43 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 16 Jan 2019 18:43:49 +0000 (13:43 -0500)
The buffer arguments to v4l2_m2m_buf_copy_data args were swapped.

The reason is confusing naming conventions in vim2m. It certainly
could be improved.

Fixes: 7aca565ee3d0 ("media: vim2m: use v4l2_m2m_buf_copy_data")

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/vim2m.c

index 33397d4..a7a152f 100644 (file)
@@ -241,7 +241,7 @@ static int device_process(struct vim2m_ctx *ctx,
        out_vb->sequence =
                get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE)->sequence++;
        in_vb->sequence = q_data->sequence++;
-       v4l2_m2m_buf_copy_data(out_vb, in_vb, true);
+       v4l2_m2m_buf_copy_data(in_vb, out_vb, true);
 
        switch (ctx->mode) {
        case MEM2MEM_HFLIP | MEM2MEM_VFLIP: