Fix SVACE warning and Coding rule warnings

Change-Id: I339b4adf2218f8d1f01d16d82e63f16208ca4924
Signed-off-by: Kiseok Chang <kiso.chang@samsung.com>

diff --git a/setting-appmgr/src/setting-appmgr-main.c b/setting-appmgr/src/setting-appmgr-main.c
index f642a82d221e0fc7f9176fcb9c1071abcffa2055..469aba80fd4de8a0505d5e421e42b28079c98cf7 100755 (executable)
--- a/setting-appmgr/src/setting-appmgr-main.c
+++ b/setting-appmgr/src/setting-appmgr-main.c
@@ -379,7 +379,7 @@ char *main_genlist_item_text_get(void *data, Evas_Object *obj,
                label = SAFE_STRDUP(node->label);
        else if (!strcmp(part, "elm.text.sub") && node->size >= 0) {
                appmgr_size_to_str(node->size, desc, sizeof(desc));
-               if(strncmp(desc, "0.00KB", 6) == 0){
+               if (strncmp(desc, "0.00KB", 6) == 0) {
                        snprintf(desc, sizeof(desc), "Loading...");
                }
 
@@ -542,7 +542,7 @@ static int _get_visible_genlist_item_ix(Evas_Object *genlist)
 static void _update_ui(SettingAppMgr *ad)
 {
        // Case to prevent second update of package size
-       if(!ad->is_invoked_by_timer && ad->is_size_set) {
+       if (!ad->is_invoked_by_timer && ad->is_size_set) {
                return;
        }
 
@@ -631,7 +631,7 @@ static void _update_ui(SettingAppMgr *ad)
                }
                tmp = NULL;
                _package_node_2_ui_node_adapter(package_node_info, &tmp);
-               if(tmp->size == 0) {
+               if (tmp->size == 0) {
                        is_zero_occure = true;
                }
                elm_genlist_item_append(
@@ -668,7 +668,7 @@ static void _update_ui(SettingAppMgr *ad)
        elm_scroller_page_show(ad->scroller, ad->tabtype, 0);
 
        //When 0 size did not appear and ensure that loop at least once went through
-       if(!is_zero_occure && did_loop_iterate) {
+       if (!is_zero_occure && did_loop_iterate) {
                ad->is_size_set = true;
        }
 }
@@ -891,7 +891,7 @@ static Eina_Bool _update_timer_cb(void *data)
 
                        SETTING_TRACE("[MS] _update_ui size_update_needed");
                        //Invoke update only once, to get right size
-                       if(!ad->is_size_set) {
+                       if (!ad->is_size_set) {
                                ad->is_invoked_by_timer = true;
                                _update_ui(ad);
                                ad->is_invoked_by_timer = false;

diff --git a/setting-network/src/setting-network-service-providers.c b/setting-network/src/setting-network-service-providers.c
index 88745e26de4d80d488eced671547ff58b66843ee..f4f5888da9e9b650c506a0fcf9d536c44c74b6aa 100755 (executable)
--- a/setting-network/src/setting-network-service-providers.c
+++ b/setting-network/src/setting-network-service-providers.c
@@ -649,10 +649,6 @@ static void _tel_get_selected_network_cb(TapiHandle *handle, int result, void *d
 
        int num = s_info.plmn_info[s_info.sim_selected].networks_count;
        int len = strlen(network->plmn);
-       if (!network) {
-               SETTING_TRACE_ERROR("network == NULL");
-               return;
-       }
        for (i = 0; i < num; ++i) {
                SETTING_TRACE("Current: (%s) <> List %s(%s)", network->plmn, network_list[i].network_name, network_list[i].plmn);