r600/sfn: Fix test for possible dest slot
authorGert Wollny <gert.wollny@collabora.com>
Sat, 17 Dec 2022 10:15:17 +0000 (11:15 +0100)
committerGert Wollny <gert.wollny@collabora.com>
Sat, 17 Dec 2022 10:15:17 +0000 (11:15 +0100)
Fixes Coverity CID 1517721

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20367>

src/gallium/drivers/r600/sfn/sfn_instr_alugroup.cpp

index 0be1f5b..60af237 100644 (file)
@@ -138,7 +138,8 @@ AluGroup::add_trans_instructions(AluInstr *instr)
                return false;
          }
 
-         while ((!m_slots[used_slot] && used_slot >= 0) || !(free_mask & (1 << used_slot)))
+         while (used_slot >= 0 &&
+                (!m_slots[used_slot] || !(free_mask & (1 << used_slot))))
             --used_slot;
 
          // if we schedule a non-trans instr into the trans slot,