hugetlb_cgroup: remove unneeded nr_pages > 0 check
authorMiaohe Lin <linmiaohe@huawei.com>
Fri, 29 Jul 2022 08:01:02 +0000 (16:01 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 Sep 2022 03:25:52 +0000 (20:25 -0700)
Patch series "A few cleanup patches for hugetlb_cgroup", v2.

This series contains a few cleaup patches to remove unneeded check, use
helper macro, remove unneeded return value and so on.  More details can be
found in the respective changelogs.

This patch (of 5):

When code reaches here, nr_pages must be > 0. Remove unneeded nr_pages > 0
check to simplify the code.

Link: https://lkml.kernel.org/r/20220729080106.12752-1-linmiaohe@huawei.com
Link: https://lkml.kernel.org/r/20220729080106.12752-2-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb_cgroup.c

index c86691c..d16eb00 100644 (file)
@@ -442,7 +442,7 @@ void hugetlb_cgroup_uncharge_file_region(struct resv_map *resv,
        if (hugetlb_cgroup_disabled() || !resv || !rg || !nr_pages)
                return;
 
-       if (rg->reservation_counter && resv->pages_per_hpage && nr_pages > 0 &&
+       if (rg->reservation_counter && resv->pages_per_hpage &&
            !resv->reservation_counter) {
                page_counter_uncharge(rg->reservation_counter,
                                      nr_pages * resv->pages_per_hpage);