usb: fotg210-hcd: use sysfs_emit() to instead of scnprintf()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 20 Jan 2023 15:44:33 +0000 (17:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jan 2023 17:12:58 +0000 (18:12 +0100)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230120154437.22025-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/fotg210/fotg210-hcd.c

index 7bd1e8f..46752a7 100644 (file)
@@ -4686,14 +4686,11 @@ static ssize_t uframe_periodic_max_show(struct device *dev,
                struct device_attribute *attr, char *buf)
 {
        struct fotg210_hcd *fotg210;
-       int n;
 
        fotg210 = hcd_to_fotg210(bus_to_hcd(dev_get_drvdata(dev)));
-       n = scnprintf(buf, PAGE_SIZE, "%d\n", fotg210->uframe_periodic_max);
-       return n;
+       return sysfs_emit(buf, "%d\n", fotg210->uframe_periodic_max);
 }
 
-
 static ssize_t uframe_periodic_max_store(struct device *dev,
                struct device_attribute *attr, const char *buf, size_t count)
 {