mei: make return values consistent across the driver
authorAlexander Usyskin <alexander.usyskin@intel.com>
Mon, 31 Mar 2014 14:59:24 +0000 (17:59 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 May 2014 23:21:23 +0000 (19:21 -0400)
Follow-up for bits missed in
commit 7ca96aa278f8b9983184e318b06a0ed9ad0297b8
mei: make return values consistent across the driver

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/bus.c
drivers/misc/mei/client.c

index ddc5ac9..d5b9ed4 100644 (file)
@@ -247,7 +247,7 @@ static int ___mei_cl_send(struct mei_cl *cl, u8 *buf, size_t length,
                return id;
 
        if (length > dev->me_clients[id].props.max_msg_length)
-               return -EINVAL;
+               return -EFBIG;
 
        cb = mei_io_cb_init(cl, NULL);
        if (!cb)
index 9273e89..3349f62 100644 (file)
@@ -768,10 +768,9 @@ int mei_cl_read_start(struct mei_cl *cl, size_t length)
 
        cb->fop_type = MEI_FOP_READ;
        if (mei_hbuf_acquire(dev)) {
-               if (mei_hbm_cl_flow_control_req(dev, cl)) {
-                       rets = -ENODEV;
+               rets = mei_hbm_cl_flow_control_req(dev, cl);
+               if (rets < 0)
                        goto out;
-               }
 
                list_add_tail(&cb->list, &dev->read_list.list);
        } else {