Revert "dmaengine: dmatest: timeout value of -1 should specify infinite wait"
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 24 Apr 2020 16:11:44 +0000 (19:11 +0300)
committerVinod Koul <vkoul@kernel.org>
Mon, 27 Apr 2020 16:17:52 +0000 (21:47 +0530)
This reverts commit ed04b7c57c3383ed4573f1d1d1dbdc1108ba0bed.

While it gives a good description what happens, the approach seems too
confusing. Let's fix it in the following patch.

Cc: Gary Hook <Gary.Hook@amd.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200424161147.16895-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dmatest.c

index a2cadfa..d020898 100644 (file)
@@ -62,7 +62,7 @@ MODULE_PARM_DESC(pq_sources,
 static int timeout = 3000;
 module_param(timeout, uint, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), "
-                "Pass 0xFFFFFFFF (4294967295) for maximum timeout");
+                "Pass -1 for infinite timeout");
 
 static bool noverify;
 module_param(noverify, bool, S_IRUGO | S_IWUSR);
@@ -98,7 +98,7 @@ MODULE_PARM_DESC(transfer_size, "Optional custom transfer size in bytes (default
  * @iterations:                iterations before stopping test
  * @xor_sources:       number of xor source buffers
  * @pq_sources:                number of p+q source buffers
- * @timeout:           transfer timeout in msec, 0 - 0xFFFFFFFF (4294967295)
+ * @timeout:           transfer timeout in msec, -1 for infinite timeout
  */
 struct dmatest_params {
        unsigned int    buf_size;
@@ -109,7 +109,7 @@ struct dmatest_params {
        unsigned int    iterations;
        unsigned int    xor_sources;
        unsigned int    pq_sources;
-       unsigned int    timeout;
+       int             timeout;
        bool            noverify;
        bool            norandom;
        int             alignment;