s390: Simplify the calculation of variables
authorJiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Tue, 26 Jan 2021 09:09:12 +0000 (17:09 +0800)
committerVasily Gorbik <gor@linux.ibm.com>
Tue, 9 Feb 2021 14:57:04 +0000 (15:57 +0100)
Fix the following coccicheck warnings:

./arch/s390/include/asm/scsw.h:528:48-50: WARNING !A || A && B is
equivalent to !A || B.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
arch/s390/include/asm/scsw.h

index c00f7b0..a7c3ccf 100644 (file)
@@ -525,8 +525,7 @@ static inline int scsw_cmd_is_valid_pno(union scsw *scsw)
        return (scsw->cmd.fctl != 0) &&
               (scsw->cmd.stctl & SCSW_STCTL_STATUS_PEND) &&
               (!(scsw->cmd.stctl & SCSW_STCTL_INTER_STATUS) ||
-                ((scsw->cmd.stctl & SCSW_STCTL_INTER_STATUS) &&
-                 (scsw->cmd.actl & SCSW_ACTL_SUSPENDED)));
+                 (scsw->cmd.actl & SCSW_ACTL_SUSPENDED));
 }
 
 /**