scsi: bnx2i: Use zeroing allocator rather than allocator/memset

Use dma_zalloc_coherent instead of dma_alloc_coherent followed by
memset 0.

Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index 9e3bf53..8f03a86 100644 (file)
--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
@@ -1070,15 +1070,14 @@ int bnx2i_alloc_qp_resc(struct bnx2i_hba *hba, struct bnx2i_endpoint *ep)
 
        /* Allocate memory area for actual SQ element */
        ep->qp.sq_virt =
-               dma_alloc_coherent(&hba->pcidev->dev, ep->qp.sq_mem_size,
-                                  &ep->qp.sq_phys, GFP_KERNEL);
+               dma_zalloc_coherent(&hba->pcidev->dev, ep->qp.sq_mem_size,
+                                       &ep->qp.sq_phys, GFP_KERNEL);
        if (!ep->qp.sq_virt) {
                printk(KERN_ALERT "bnx2i: unable to alloc SQ BD memory %d\n",
                                  ep->qp.sq_mem_size);
                goto mem_alloc_err;
        }
 
-       memset(ep->qp.sq_virt, 0x00, ep->qp.sq_mem_size);
        ep->qp.sq_first_qe = ep->qp.sq_virt;
        ep->qp.sq_prod_qe = ep->qp.sq_first_qe;
        ep->qp.sq_cons_qe = ep->qp.sq_first_qe;
@@ -1107,14 +1106,13 @@ int bnx2i_alloc_qp_resc(struct bnx2i_hba *hba, struct bnx2i_endpoint *ep)
 
        /* Allocate memory area for actual CQ element */
        ep->qp.cq_virt =
-               dma_alloc_coherent(&hba->pcidev->dev, ep->qp.cq_mem_size,
-                                  &ep->qp.cq_phys, GFP_KERNEL);
+               dma_zalloc_coherent(&hba->pcidev->dev, ep->qp.cq_mem_size,
+                                       &ep->qp.cq_phys, GFP_KERNEL);
        if (!ep->qp.cq_virt) {
                printk(KERN_ALERT "bnx2i: unable to alloc CQ BD memory %d\n",
                                  ep->qp.cq_mem_size);
                goto mem_alloc_err;
        }
-       memset(ep->qp.cq_virt, 0x00, ep->qp.cq_mem_size);
 
        ep->qp.cq_first_qe = ep->qp.cq_virt;
        ep->qp.cq_prod_qe = ep->qp.cq_first_qe;