tools, bpf_asm: Exit non-zero on errors
authorIan Denhardt <ian@zenhack.net>
Wed, 24 Feb 2021 02:24:00 +0000 (21:24 -0500)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 26 Feb 2021 21:53:50 +0000 (22:53 +0100)
... so callers can correctly detect failure.

Signed-off-by: Ian Denhardt <ian@zenhack.net>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/b0bea780bc292f29e7b389dd062f20adc2a2d634.1614201868.git.ian@zenhack.net
tools/bpf/bpf_exp.y

index 8d03e52..dfb7254 100644 (file)
@@ -185,13 +185,13 @@ ldx
        | OP_LDXB number '*' '(' '[' number ']' '&' number ')' {
                if ($2 != 4 || $9 != 0xf) {
                        fprintf(stderr, "ldxb offset not supported!\n");
-                       exit(0);
+                       exit(1);
                } else {
                        bpf_set_curr_instr(BPF_LDX | BPF_MSH | BPF_B, 0, 0, $6); } }
        | OP_LDX number '*' '(' '[' number ']' '&' number ')' {
                if ($2 != 4 || $9 != 0xf) {
                        fprintf(stderr, "ldxb offset not supported!\n");
-                       exit(0);
+                       exit(1);
                } else {
                        bpf_set_curr_instr(BPF_LDX | BPF_MSH | BPF_B, 0, 0, $6); } }
        ;
@@ -472,7 +472,7 @@ static void bpf_assert_max(void)
 {
        if (curr_instr >= BPF_MAXINSNS) {
                fprintf(stderr, "only max %u insns allowed!\n", BPF_MAXINSNS);
-               exit(0);
+               exit(1);
        }
 }
 
@@ -522,7 +522,7 @@ static int bpf_find_insns_offset(const char *label)
 
        if (ret == -ENOENT) {
                fprintf(stderr, "no such label \'%s\'!\n", label);
-               exit(0);
+               exit(1);
        }
 
        return ret;