mwifiex: remove unnecessary call to memset
authorHimanshu Jha <himanshujha199640@gmail.com>
Mon, 11 Sep 2017 12:46:04 +0000 (18:16 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 20 Sep 2017 12:46:59 +0000 (15:46 +0300)
call to memset to assign 0 value immediately after allocating
memory with kzalloc is unnecesaary as kzalloc allocates the memory
filled with 0 value.

Semantic patch used to resolve this issue:

@@
expression e,e2; constant c;
statement S;
@@

  e = kzalloc(e2, c);
  if(e == NULL) S
- memset(e, 0, e2);

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/marvell/mwifiex/scan.c

index c9d41ed..8838b88 100644 (file)
@@ -1936,8 +1936,6 @@ mwifiex_active_scan_req_for_passive_chan(struct mwifiex_private *priv)
        if (!user_scan_cfg)
                return -ENOMEM;
 
-       memset(user_scan_cfg, 0, sizeof(*user_scan_cfg));
-
        for (id = 0; id < MWIFIEX_USER_SCAN_CHAN_MAX; id++) {
                if (!priv->hidden_chan[id].chan_number)
                        break;