[Common][Filesystem] Added error messages.

[Features] Commit migrated from tv branch.
http://165.213.149.170/gerrit/#/c/78321/

[Verification] Code compiles.

Change-Id: I97029dd0964bf7ac229b2e23bf736b854aa6a600
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>

diff --git a/src/common/current_application.cc b/src/common/current_application.cc
index fc08be08d58c1efebe22a04316ce3f1e919aeb86..85910ccf690cfe488e1aa606ddb86d15ac97f4d4 100755 (executable)
--- a/src/common/current_application.cc
+++ b/src/common/current_application.cc
@@ -62,7 +62,7 @@ std::string CurrentApplication::FetchApplicationId() const {
   if ((APP_MANAGER_ERROR_NONE == ret) && (nullptr != tmp_str)) {
     app_id = tmp_str;
   } else {
-    LoggerE("Failed to get application ID.");
+    LoggerE("Failed to get application ID: %d (%s)", ret, get_error_message(ret));
   }
 
   free(tmp_str);
@@ -81,7 +81,7 @@ std::string CurrentApplication::FetchPackageId() const {
   if ((PACKAGE_MANAGER_ERROR_NONE == ret) && (nullptr != tmp_str)) {
     package_id = tmp_str;
   } else {
-    LoggerE("Failed to get package ID.");
+    LoggerE("Can't get package name from app info: %d (%s)", ret, get_error_message(ret));
   }
 
   free(tmp_str);

diff --git a/src/common/virtual_fs.cc b/src/common/virtual_fs.cc
index 78d5f9d3b37ca8ca492c529996917183bc223e79..01991b1f25f35c94fdb47cb473440dc2e606a368 100755 (executable)
--- a/src/common/virtual_fs.cc
+++ b/src/common/virtual_fs.cc
@@ -94,7 +94,8 @@ common::optional<std::string> GetRootDir() {
   app_info_h app_info;
   int err = app_info_create(app_id.c_str(), &app_info);
   if (APP_MANAGER_ERROR_NONE != err) {
-    LoggerE("Can't create app info handle from appId (%s)", app_id.c_str());
+    LoggerE("Can't create app info handle from appId (%s): %d (%s)", app_id.c_str(), err,
+            get_error_message(err));
     return nullptr;
   }
   SCOPE_EXIT {
@@ -232,8 +233,8 @@ VirtualFs::VirtualFs() : app_root_(GetRootDir()) {
 
   int err = storage_foreach_device_supported(OnStorageDeviceSupported, nullptr);
 
-  if (err != STORAGE_ERROR_NONE) {
-    LoggerE("Unknown Error on getting storage paths");
+  if (STORAGE_ERROR_NONE != err) {
+    LoggerE("Unknown Error on getting storage paths %d (%s)", err, get_error_message(err));
   }
 
   int id = -1;

diff --git a/src/filesystem/filesystem_utils.cc b/src/filesystem/filesystem_utils.cc
index 7bc374dd442c9a41c48b74b11a6dfea5063a8f0d..c437b3185d620371c621879847d0d9f70d3ad8d9 100755 (executable)
--- a/src/filesystem/filesystem_utils.cc
+++ b/src/filesystem/filesystem_utils.cc
@@ -24,8 +24,9 @@ std::string get_storage_dir_path(int id, storage_directory_e typeToCheck) {
   LoggerD("Enter");
   char* platformPath = NULL;
   int result = storage_get_directory(id, typeToCheck, &platformPath);
-  if (result != STORAGE_ERROR_NONE) {
-    LoggerD("Cannot retrieve path for type %i", typeToCheck);
+  if (STORAGE_ERROR_NONE != result) {
+    LoggerD("Cannot retrieve path for type %i: %d (%s)", typeToCheck, result,
+            get_error_message(result));
     return std::string();
   }
   std::string path = std::string(platformPath);