agent: Delay signal emission after the lock has been released

This way, there can be no annoying re-entrancy in our code.

diff --git a/agent/agent.c b/agent/agent.c
index 4395f3b..689a2f6 100644 (file)
--- a/agent/agent.c
+++ b/agent/agent.c
@@ -3724,8 +3724,9 @@ component_io_cb (GSocket *socket, GIOCondition condition, gpointer user_data)
   if (g_source_is_destroyed (g_main_current_source ())) {
     /* Silently return FALSE. */
     nice_debug ("%s: source %p destroyed", G_STRFUNC, g_main_current_source ());
-    remove_source = TRUE;
-    goto done;
+
+    agent_unlock ();
+    return G_SOURCE_REMOVE;
   }
 
   component = socket_source->component;
@@ -3875,10 +3876,11 @@ component_io_cb (GSocket *socket, GIOCondition condition, gpointer user_data)
   }
 
 done:
-  g_object_unref (agent);
 
   agent_unlock_and_emit (agent);
 
+  g_object_unref (agent);
+
   return !remove_source;
 }