drivers/scsi/aic94xx/aic94xx_init.c: correct the size argument to kmalloc
authorJulia Lawall <julia@diku.dk>
Wed, 11 Aug 2010 01:01:18 +0000 (18:01 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 11 Aug 2010 15:59:00 +0000 (08:59 -0700)
In each case, the destination of the allocation has type struct **, so the
elements of the array should have pointer type, not structure type.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@disable sizeof_type_expr@
type T;
T **x;
@@

  x =
  <+...sizeof(
- T
+ *x
  )...+>
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Joe Perches <joe@perches.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/aic94xx/aic94xx_init.c
drivers/scsi/ch.c

index 24ac231..3b7e83d 100644 (file)
@@ -688,9 +688,9 @@ static int asd_register_sas_ha(struct asd_ha_struct *asd_ha)
 {
        int i;
        struct asd_sas_phy   **sas_phys =
-               kmalloc(ASD_MAX_PHYS * sizeof(struct asd_sas_phy), GFP_KERNEL);
+               kcalloc(ASD_MAX_PHYS, sizeof(*sas_phys), GFP_KERNEL);
        struct asd_sas_port  **sas_ports =
-               kmalloc(ASD_MAX_PHYS * sizeof(struct asd_sas_port), GFP_KERNEL);
+               kcalloc(ASD_MAX_PHYS, sizeof(*sas_ports), GFP_KERNEL);
 
        if (!sas_phys || !sas_ports) {
                kfree(sas_phys);
index 4799d43..769b35f 100644 (file)
@@ -352,7 +352,7 @@ ch_readconfig(scsi_changer *ch)
        }
 
        /* look up the devices of the data transfer elements */
-       ch->dt = kmalloc(ch->counts[CHET_DT]*sizeof(struct scsi_device),
+       ch->dt = kcalloc(ch->counts[CHET_DT], sizeof(*ch->dt),
                         GFP_KERNEL);
 
        if (!ch->dt) {