staging: netlogic: Remove unnecessary error print
authorHimadri Pandya <himadri18.07@gmail.com>
Thu, 21 Mar 2019 09:57:17 +0000 (15:27 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Mar 2019 19:08:07 +0000 (20:08 +0100)
Kmalloc normally produces a backtrace when there is not enough memory.
So it is unnecessary to print an error message that provides only this
information. Hence, remove pr_error() from memory allocation check.
Issue found using Coccinelle.

Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/netlogic/xlr_net.c

index 1897b71..07a06c5 100644 (file)
@@ -386,10 +386,8 @@ static void *xlr_config_spill(struct xlr_net_priv *priv, int reg_start_0,
        base = priv->base_addr;
        spill_size = size;
        spill = kmalloc(spill_size + SMP_CACHE_BYTES, GFP_ATOMIC);
-       if (!spill) {
-               pr_err("Unable to allocate memory for spill area!\n");
+       if (!spill)
                return ZERO_SIZE_PTR;
-       }
 
        spill = PTR_ALIGN(spill, SMP_CACHE_BYTES);
        phys_addr = virt_to_phys(spill);