[Build] Enforce -Wall / -Werror

Let's not tolerate compiler warnings in this project from now on.

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

diff --git a/CMakeLists.txt b/CMakeLists.txt
index a40ab8a..c60095c 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -40,7 +40,7 @@ LINK_DIRECTORIES(${pkgs_LIBRARY_DIRS})
 FOREACH(flag ${pkgs_CFALGS})
        SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${flag}")
 ENDFOREACH(flag)
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS}")
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -Wall -Werror ")
 
 ADD_SUBDIRECTORY(tensor_converter)
 ADD_SUBDIRECTORY(tensor_filter)

diff --git a/tensor_converter/tensor_converter.c b/tensor_converter/tensor_converter.c
index 3136dbf..5ddd3a2 100644 (file)
--- a/tensor_converter/tensor_converter.c
+++ b/tensor_converter/tensor_converter.c
@@ -263,7 +263,6 @@ gst_tensor_converter_configure_tensor(const GstCaps *caps, GstTensor_Converter *
   gint framerate_denominator;
   gsize tensorFrameSize;
   gboolean ret;
-  GstCaps *outcaps;
   const gchar *format;
   int i;
 
@@ -638,7 +637,7 @@ static gboolean gst_tensor_converter_set_caps(GstBaseTransform *trans,
    *  However, we do not have subclass (This is the concrete class)
    */
   GstTensor_Converter *filter = GST_TENSOR_CONVERTER_CAST(trans);
-  GstVideoInfo in_info, out_info;
+  GstVideoInfo in_info;
 
   GST_DEBUG_OBJECT (trans, "converting from  %" GST_PTR_FORMAT
       " to %" GST_PTR_FORMAT, incaps, outcaps);
@@ -656,5 +655,7 @@ static gboolean gst_tensor_converter_set_caps(GstBaseTransform *trans,
   filter->negotiated = gst_tensor_converter_configure_tensor(incaps, filter);
 
   /* @TODO Verity if outcaps and filter conf are compatible */
+  /* @TODO THIS IS REQUIRED TO FILL IN: Return FALSE if filter is not compatible with outcaps */
 
+  return TRUE;
 }

diff --git a/tensor_filter/tensor_filter.c b/tensor_filter/tensor_filter.c
index 1a209f7..a0e6bc3 100644 (file)
--- a/tensor_filter/tensor_filter.c
+++ b/tensor_filter/tensor_filter.c
@@ -86,6 +86,16 @@
 GstTensor_Filter_Framework *tensor_filter_supported[] = {
   &NNS_support_tensorflow_lite,
 };
+const char* nnfw_names[] = {
+  "Not supported",
+
+  "custom",
+  "tensorflow-lite",
+  "tensorflow",
+  "caffe2",
+
+  0,
+};
 
 GST_DEBUG_CATEGORY_STATIC (gst_tensor_filter_debug);
 #define GST_CAT_DEFAULT gst_tensor_filter_debug
@@ -320,12 +330,6 @@ gst_tensor_filter_get_property (GObject * object, guint prop_id,
  * GstElement vmethod implementations
  */
 
-/* Configure tensor metadata from sink caps */
-static gboolean
-gst_tensor_filter_configure_tensor(const GstCaps *caps, GstTensor_Filter *filter) {
-}
-
-
 /* entry point to initialize the plug-in
  * initialize the plug-in itself
  * register the element factories and other features
@@ -395,6 +399,7 @@ static GstCaps* gst_tensor_filter_transform_caps(GstBaseTransform *trans,
                                                  GstCaps *caps,
                                                  GstCaps *filter)
 {
+  return NULL;
 }
 
 static GstCaps* gst_tensor_filter_fixate_caps(GstBaseTransform *trans,
@@ -402,10 +407,12 @@ static GstCaps* gst_tensor_filter_fixate_caps(GstBaseTransform *trans,
                                               GstCaps *caps,
                                               GstCaps *othercaps)
 {
+  return NULL;
 }
 
 static gboolean gst_tensor_filter_set_caps(GstBaseTransform *trans,
                                             GstCaps *incaps,
                                            GstCaps *outcaps)
 {
+  return FALSE;
 }

diff --git a/tensor_filter/tensor_filter.h b/tensor_filter/tensor_filter.h
index b55aa19..c8b2634 100644 (file)
--- a/tensor_filter/tensor_filter.h
+++ b/tensor_filter/tensor_filter.h
@@ -93,21 +93,7 @@ typedef enum _nnfw_type {
   _T_F_NNFW_END,
 } nnfw_type;
 
-/**
- * @brief NN Framework Names
- *
- * These strings are used to search f/w from property input.
- */
-static const char* nnfw_names[] = {
-  "Not supported",
-
-  "custom",
-  "tensorflow-lite",
-  "tensorflow",
-  "caffe2",
-
-  0,
-};
+extern const char* nnfw_names[];
 
 /**
  * @brief NN Framework Support Status