gpio: sifive: add missing check for platform_get_irq
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Tue, 6 Jun 2023 03:11:59 +0000 (11:11 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Jun 2023 09:12:34 +0000 (11:12 +0200)
[ Upstream commit c1bcb976d8feb107ff2c12caaf12ac5e70f44d5f ]

Add the missing check for platform_get_irq() and return error code
if it fails.

The returned error code will be dealed with in
builtin_platform_driver(sifive_gpio_driver) and the driver will not
be registered.

Fixes: f52d6d8b43e5 ("gpio: sifive: To get gpio irq offset from device tree data")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-sifive.c

index bc5660f61c570d770a2d5cb44ee6bd2768aa6189..0f1e1226ebbe84ad0499bf6c0cfa5005f31ceee7 100644 (file)
@@ -221,8 +221,12 @@ static int sifive_gpio_probe(struct platform_device *pdev)
                return -ENODEV;
        }
 
-       for (i = 0; i < ngpio; i++)
-               chip->irq_number[i] = platform_get_irq(pdev, i);
+       for (i = 0; i < ngpio; i++) {
+               ret = platform_get_irq(pdev, i);
+               if (ret < 0)
+                       return ret;
+               chip->irq_number[i] = ret;
+       }
 
        ret = bgpio_init(&chip->gc, dev, 4,
                         chip->base + SIFIVE_GPIO_INPUT_VAL,