bcma: gpio: remove redundant re-assignment of chip->owner
authorColin Ian King <colin.i.king@gmail.com>
Thu, 3 Mar 2022 08:58:41 +0000 (08:58 +0000)
committerKalle Valo <kvalo@kernel.org>
Thu, 10 Mar 2022 16:17:53 +0000 (18:17 +0200)
There are two identical assignments of chip->owner to the same value,
the second assignment is redundant and can be removed.

Cleans up cppcheck warning:
drivers/bcma/driver_gpio.c:184:15: style: Variable 'chip->owner' is
reassigned a value before the old one has been used. [redundantAssignment]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220303085841.1124766-1-colin.i.king@gmail.com
drivers/bcma/driver_gpio.c

index 8a1e470..1e74ec1 100644 (file)
@@ -181,7 +181,6 @@ int bcma_gpio_init(struct bcma_drv_cc *cc)
        chip->set               = bcma_gpio_set_value;
        chip->direction_input   = bcma_gpio_direction_input;
        chip->direction_output  = bcma_gpio_direction_output;
-       chip->owner             = THIS_MODULE;
        chip->parent            = bus->dev;
 #if IS_BUILTIN(CONFIG_OF)
        chip->of_node           = cc->core->dev.of_node;