Fix various printf format issues in debug messages

diff --git a/ges/ges-base-xml-formatter.c b/ges/ges-base-xml-formatter.c
index 40268b1c390a153cba46f78dfd1b4271f1109201..ca507fcedef5f77cdcfb9b78bcecf7da2f905489 100644 (file)
--- a/ges/ges-base-xml-formatter.c
+++ b/ges/ges-base-xml-formatter.c
@@ -418,7 +418,7 @@ _add_object_to_layer (GESBaseXmlFormatterPrivate * priv, const gchar * id,
       asset, start, inpoint, duration, rate, track_types);
 
   if (tlobj == NULL) {
-    GST_WARNING_OBJECT ("Could not add object from asset: %s",
+    GST_WARNING_OBJECT (tlobj, "Could not add object from asset: %s",
         ges_asset_get_id (asset));
 
     return NULL;

diff --git a/ges/ges-project.c b/ges/ges-project.c
index efb7f2d39e19cc14076b54deab2b28a5d534a6f9..bf01bcc37c5a6f7f69ee1703ba38dcd9cc56d04a 100644 (file)
--- a/ges/ges-project.c
+++ b/ges/ges-project.c
@@ -736,8 +736,9 @@ ges_project_save (GESProject * project, GESTimeline * timeline,
 
   formatter = GES_FORMATTER (ges_asset_extract (formatter_asset, error));
   if (formatter == NULL) {
-    GST_WARNING_OBJECT (project, "Could not create the formatter %s: Error: %s",
-        formatter_asset, (error && *error) ? (*error)->message : "Unknown");
+    GST_WARNING_OBJECT (project, "Could not create the formatter %p %s: %s",
+        formatter_asset, ges_asset_get_id (formatter_asset),
+        (error && *error) ? (*error)->message : "Unknown Error");
 
     ret = FALSE;
     goto out;

diff --git a/ges/ges-timeline-layer.c b/ges/ges-timeline-layer.c
index 957a23ba6c14d7b992bef6e191301b83834ac0e9..c531c92afa3907bf19b4e5f997e3d1c6e36914e2 100644 (file)
--- a/ges/ges-timeline-layer.c
+++ b/ges/ges-timeline-layer.c
@@ -593,7 +593,7 @@ ges_timeline_layer_add_asset (GESTimelineLayer * layer,
           (asset), GES_TYPE_TIMELINE_OBJECT), NULL);
 
   GST_DEBUG_OBJECT (layer, "Adding asset %s with: start: %" GST_TIME_FORMAT
-      " inpoint: %" GST_TIME_FORMAT " duration: %" GST_TIME_FORMAT " rate %d"
+      " inpoint: %" GST_TIME_FORMAT " duration: %" GST_TIME_FORMAT " rate %f"
       " track types: %d (%s)", ges_asset_get_id (asset), GST_TIME_ARGS (start),
       GST_TIME_ARGS (inpoint), GST_TIME_ARGS (duration), rate, track_types,
       ges_track_type_name (track_types));

diff --git a/ges/ges-timeline-object.c b/ges/ges-timeline-object.c
index 4b9187b08d15d62d7c98afffb62cf3dad0af6c9b..91346ea66fa8ec9bcf8a49b303065343ea7c22da 100644 (file)
--- a/ges/ges-timeline-object.c
+++ b/ges/ges-timeline-object.c
@@ -799,7 +799,7 @@ ges_timeline_object_set_start_internal (GESTimelineObject * object,
 
   g_return_val_if_fail (GES_IS_TIMELINE_OBJECT (object), FALSE);
 
-  GST_DEBUG_OBJECT (object, "current start: %" GST_TIME_FORMAT,
+  GST_DEBUG_OBJECT (object, "current start: %" GST_TIME_FORMAT
       " new start: %" GST_TIME_FORMAT, GST_TIME_ARGS (start),
       GST_TIME_ARGS (object->start));
 
@@ -869,7 +869,7 @@ ges_timeline_object_set_inpoint_internal (GESTimelineObject * object,
 
   g_return_val_if_fail (GES_IS_TIMELINE_OBJECT (object), FALSE);
 
-  GST_DEBUG_OBJECT (object, "current inpoint: %" GST_TIME_FORMAT,
+  GST_DEBUG_OBJECT (object, "current inpoint: %" GST_TIME_FORMAT
       " new inpoint: %" GST_TIME_FORMAT, GST_TIME_ARGS (inpoint),
       GST_TIME_ARGS (object->inpoint));
 
@@ -912,7 +912,7 @@ ges_timeline_object_set_duration_internal (GESTimelineObject * object,
 
   g_return_val_if_fail (GES_IS_TIMELINE_OBJECT (object), FALSE);
 
-  GST_DEBUG_OBJECT (object, "current duration: %" GST_TIME_FORMAT,
+  GST_DEBUG_OBJECT (object, "current duration: %" GST_TIME_FORMAT
       " new duration: %" GST_TIME_FORMAT, GST_TIME_ARGS (duration),
       GST_TIME_ARGS (object->duration));
 

diff --git a/ges/ges-track-object.c b/ges/ges-track-object.c
index 0f456a4b88ffa9374e5e78f23742d9f6d182e9d9..ac482fab0732d82a765e613c2b7e8a130bfae3b8 100644 (file)
--- a/ges/ges-track-object.c
+++ b/ges/ges-track-object.c
@@ -1675,7 +1675,7 @@ default_list_children_properties (GESTrackObject * object, guint * n_properties)
 prop_hash_not_set:
   {
     *n_properties = 0;
-    GST_DEBUG_OBJECT (object, "The child properties haven't been set on %p");
+    GST_DEBUG_OBJECT (object, "No child properties have been set yet");
     return NULL;
   }
 }

diff --git a/tests/check/ges/simplelayer.c b/tests/check/ges/simplelayer.c
index 4d8e7752594514c85e127504cd5d925c4ff18349..c9dc81f68b4da483e3ec1fe0868d14dc9520a43a 100644 (file)
--- a/tests/check/ges/simplelayer.c
+++ b/tests/check/ges/simplelayer.c
@@ -48,7 +48,7 @@ arbitrary_fill_track_func (GESTimelineObject * object,
   g_assert (user_data);
 
   GST_DEBUG ("element:%s, timelineobj:%p, trackobjects:%p, gnlobj:%p,",
-      user_data, object, trobject, gnlobj);
+      (const gchar *) user_data, object, trobject, gnlobj);
 
   /* interpret user_data as name of element to create */
   src = gst_element_factory_make (user_data, NULL);