Follow up for "[lit] Include unexecuted tests in xUnit report"
authorJulian Lettner <julian.lettner@apple.com>
Mon, 15 Jun 2020 23:15:28 +0000 (16:15 -0700)
committerJulian Lettner <julian.lettner@apple.com>
Mon, 15 Jun 2020 23:19:43 +0000 (16:19 -0700)
The extended test fails on bots that still run lit tests with Python 2.

https://reviews.llvm.org/D81316

llvm/utils/lit/tests/Inputs/xunit-output/dummy_format.py

index 94410d2..59e75eb 100644 (file)
@@ -23,9 +23,10 @@ class DummyFormat(lit.formats.FileBasedTest):
         result = lit.Test.Result(getattr(lit.Test, result_code),
                                  result_output)
 
-        required_feature = cfg.get('global', 'required_feature', fallback=None)
-        if required_feature:
-            test.requires.append(required_feature)
+        if cfg.has_option('global', 'required_feature'):
+            required_feature = cfg.get('global', 'required_feature')
+            if required_feature:
+                test.requires.append(required_feature)
 
         # Load additional metrics.
         for key,value_str in cfg.items('results'):