drm/amd/display: Set initial value to a divider
authorMikita Lipski <mikita.lipski@amd.com>
Wed, 26 Aug 2020 12:00:42 +0000 (08:00 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Apr 2021 20:52:08 +0000 (16:52 -0400)
[why/how]
Due to compiler optimization the values would be
passed to the division function uninitialized
causing a div by zero. Initialize the numerator
and denominator to 0 and 1 to prevent division
by zero.

Signed-off-by: Mikita Lipski <mikita.lipski@amd.com>
Acked-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link.c

index b2b6e26..29bc287 100644 (file)
@@ -2891,8 +2891,8 @@ static struct fixed31_32 get_pbn_per_slot(struct dc_stream_state *stream)
 static struct fixed31_32 get_pbn_from_bw_in_kbps(uint64_t kbps)
 {
        struct fixed31_32 peak_kbps;
-       uint32_t numerator;
-       uint32_t denominator;
+       uint32_t numerator = 0;
+       uint32_t denominator = 1;
 
        /*
         * margin 5300ppm + 300ppm ~ 0.6% as per spec, factor is 1.006