staging: HalBtc8723b2Ant: remove useless typedef's
authorMarco Cesati <marcocesati@gmail.com>
Fri, 5 Mar 2021 10:11:51 +0000 (11:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:25:33 +0000 (09:25 +0100)
This commit fixes the following checkpatch.pl warnings:

    WARNING: do not add new typedefs
    #19: FILE: hal/HalBtc8723b2Ant.h:19:
    +typedef enum _BT_INFO_SRC_8723B_2ANT {

    WARNING: do not add new typedefs
    #26: FILE: hal/HalBtc8723b2Ant.h:26:
    +typedef enum _BT_8723B_2ANT_BT_STATUS {

    WARNING: do not add new typedefs
    #36: FILE: hal/HalBtc8723b2Ant.h:36:
    +typedef enum _BT_8723B_2ANT_COEX_ALGO {

    WARNING: do not add new typedefs
    #51: FILE: hal/HalBtc8723b2Ant.h:51:
    +typedef struct _COEX_DM_8723B_2ANT {

    WARNING: do not add new typedefs
    #104: FILE: hal/HalBtc8723b2Ant.h:104:
    +typedef struct _COEX_STA_8723B_2ANT {

Signed-off-by: Marco Cesati <marco.cesati@gmail.com>
Link: https://lore.kernel.org/r/20210305101151.13137-1-marco.cesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.h

index 2779dba..0ca14f4 100644 (file)
@@ -15,10 +15,10 @@ do {                                                                              \
 } while (0)
 
 /*  Global variables, these are static variables */
-static COEX_DM_8723B_2ANT GLCoexDm8723b2Ant;
-static PCOEX_DM_8723B_2ANT pCoexDm = &GLCoexDm8723b2Ant;
-static COEX_STA_8723B_2ANT GLCoexSta8723b2Ant;
-static PCOEX_STA_8723B_2ANT pCoexSta = &GLCoexSta8723b2Ant;
+static struct COEX_DM_8723B_2ANT GLCoexDm8723b2Ant;
+static struct COEX_DM_8723B_2ANT * pCoexDm = &GLCoexDm8723b2Ant;
+static struct COEX_STA_8723B_2ANT GLCoexSta8723b2Ant;
+static struct COEX_STA_8723B_2ANT * pCoexSta = &GLCoexSta8723b2Ant;
 
 static const char *const GLBtInfoSrc8723b2Ant[] = {
        "BT Info[wifi fw]",
index df973fc..9d4b5f5 100644 (file)
 
 #define                BTC_RSSI_COEX_THRESH_TOL_8723B_2ANT             2
 
-typedef enum _BT_INFO_SRC_8723B_2ANT {
+enum BT_INFO_SRC_8723B_2ANT {
        BT_INFO_SRC_8723B_2ANT_WIFI_FW        = 0x0,
        BT_INFO_SRC_8723B_2ANT_BT_RSP         = 0x1,
        BT_INFO_SRC_8723B_2ANT_BT_ACTIVE_SEND = 0x2,
        BT_INFO_SRC_8723B_2ANT_MAX
-} BT_INFO_SRC_8723B_2ANT, *PBT_INFO_SRC_8723B_2ANT;
+};
 
-typedef enum _BT_8723B_2ANT_BT_STATUS {
+enum BT_8723B_2ANT_BT_STATUS {
        BT_8723B_2ANT_BT_STATUS_NON_CONNECTED_IDLE = 0x0,
        BT_8723B_2ANT_BT_STATUS_CONNECTED_IDLE     = 0x1,
        BT_8723B_2ANT_BT_STATUS_INQ_PAGE           = 0x2,
@@ -31,9 +31,9 @@ typedef enum _BT_8723B_2ANT_BT_STATUS {
        BT_8723B_2ANT_BT_STATUS_SCO_BUSY           = 0x4,
        BT_8723B_2ANT_BT_STATUS_ACL_SCO_BUSY       = 0x5,
        BT_8723B_2ANT_BT_STATUS_MAX
-} BT_8723B_2ANT_BT_STATUS, *PBT_8723B_2ANT_BT_STATUS;
+};
 
-typedef enum _BT_8723B_2ANT_COEX_ALGO {
+enum BT_8723B_2ANT_COEX_ALGO {
        BT_8723B_2ANT_COEX_ALGO_UNDEFINED       = 0x0,
        BT_8723B_2ANT_COEX_ALGO_SCO             = 0x1,
        BT_8723B_2ANT_COEX_ALGO_HID             = 0x2,
@@ -46,9 +46,9 @@ typedef enum _BT_8723B_2ANT_COEX_ALGO {
        BT_8723B_2ANT_COEX_ALGO_HID_A2DP_PANEDR = 0x9,
        BT_8723B_2ANT_COEX_ALGO_HID_A2DP        = 0xa,
        BT_8723B_2ANT_COEX_ALGO_MAX             = 0xb,
-} BT_8723B_2ANT_COEX_ALGO, *PBT_8723B_2ANT_COEX_ALGO;
+};
 
-typedef struct _COEX_DM_8723B_2ANT {
+struct COEX_DM_8723B_2ANT {
        /*  fw mechanism */
        u8 preBtDecPwrLvl;
        u8 curBtDecPwrLvl;
@@ -99,9 +99,9 @@ typedef struct _COEX_DM_8723B_2ANT {
 
        bool bNeedRecover0x948;
        u32 backup0x948;
-} COEX_DM_8723B_2ANT, *PCOEX_DM_8723B_2ANT;
+};
 
-typedef struct _COEX_STA_8723B_2ANT {
+struct COEX_STA_8723B_2ANT {
        bool bBtLinkExist;
        bool bScoExist;
        bool bA2dpExist;
@@ -124,7 +124,7 @@ typedef struct _COEX_STA_8723B_2ANT {
        bool bC2hBtInquiryPage;
        u8 btRetryCnt;
        u8 btInfoExt;
-} COEX_STA_8723B_2ANT, *PCOEX_STA_8723B_2ANT;
+};
 
 /*  */
 /*  The following is interface which will notify coex module. */