ACPI: platform-profile: Introduce object pointers to callbacks
authorJiaxun Yang <jiaxun.yang@flygoat.com>
Mon, 25 Jan 2021 11:59:57 +0000 (12:59 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 27 Jan 2021 17:45:29 +0000 (18:45 +0100)
Add an object pointer to handler callbacks to avoid the need for
drivers to have a global variable to get to their driver-data
struct.

Link: https://lore.kernel.org/linux-acpi/6a29f338-d9e4-150c-81dd-2ffb54f5bc35@redhat.com/
Link: https://lore.kernel.org/r/20210114073429.176462-3-jiaxun.yang@flygoat.com
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/platform_profile.c
include/linux/platform_profile.h

index f65c61d..80e9df4 100644 (file)
@@ -64,7 +64,7 @@ static ssize_t platform_profile_show(struct device *dev,
                return -ENODEV;
        }
 
-       err = cur_profile->profile_get(&profile);
+       err = cur_profile->profile_get(cur_profile, &profile);
        mutex_unlock(&profile_lock);
        if (err)
                return err;
@@ -104,7 +104,7 @@ static ssize_t platform_profile_store(struct device *dev,
                return -EOPNOTSUPP;
        }
 
-       err = cur_profile->profile_set(i);
+       err = cur_profile->profile_set(cur_profile, i);
        mutex_unlock(&profile_lock);
        if (err)
                return err;
index c797fdb..a26542d 100644 (file)
@@ -28,8 +28,10 @@ enum platform_profile_option {
 
 struct platform_profile_handler {
        unsigned long choices[BITS_TO_LONGS(PLATFORM_PROFILE_LAST)];
-       int (*profile_get)(enum platform_profile_option *profile);
-       int (*profile_set)(enum platform_profile_option profile);
+       int (*profile_get)(struct platform_profile_handler *pprof,
+                               enum platform_profile_option *profile);
+       int (*profile_set)(struct platform_profile_handler *pprof,
+                               enum platform_profile_option profile);
 };
 
 int platform_profile_register(struct platform_profile_handler *pprof);