Remove RestartFrame from live edit API

There is already non-throwing version FrameMirror.restart and RestartFrame in the livedit-debugger.js just adds a throwing wrapper around it.

Also NEEDS_STEP_IN_PROPERTY_NAME was removed, the client code can decide based on the stack_modified field if "step in" is required.

Chromium side was fixed in https://codereview.chromium.org/1249013002/

BUG=None
LOG=N

Review URL: https://codereview.chromium.org/1247363002

Cr-Commit-Position: refs/heads/master@{#29797}

diff --git a/src/liveedit-debugger.js b/src/liveedit-debugger.js
index eaa23834c964d22737de4b954a4142edd53a9cc9..af7712d8013522e0a5546d4a3324f6669434b35e 100644 (file)
--- a/src/liveedit-debugger.js
+++ b/src/liveedit-debugger.js
@@ -27,8 +27,6 @@ Debug.LiveEdit = new function() {
   // Forward declaration for minifier.
   var FunctionStatus;
 
-  var NEEDS_STEP_IN_PROPERTY_NAME = "stack_update_needs_step_in";
-
   // Applies the change to the script.
   // The change is in form of list of chunks encoded in a single array as
   // a series of triplets (pos1_start, pos1_end, pos2_end)
@@ -149,12 +147,9 @@ Debug.LiveEdit = new function() {
     var dropped_functions_number =
         CheckStackActivations(replaced_function_infos, change_log);
 
-    preview_description.stack_modified = dropped_functions_number != 0;
-
     // Our current implementation requires client to manually issue "step in"
-    // command for correct stack state.
-    preview_description[NEEDS_STEP_IN_PROPERTY_NAME] =
-        preview_description.stack_modified;
+    // command for correct stack state if the stack was modified.
+    preview_description.stack_modified = dropped_functions_number != 0;
 
     // Start with breakpoints. Convert their line/column positions and
     // temporary remove.
@@ -1103,19 +1098,6 @@ Debug.LiveEdit = new function() {
     return ProcessOldNode(old_code_tree);
   }
 
-  // Restarts call frame and returns value similar to what LiveEdit returns.
-  function RestartFrame(frame_mirror) {
-    var result = frame_mirror.restart();
-    if (IS_STRING(result)) {
-      throw new Failure("Failed to restart frame: " + result);
-    }
-    var result = {};
-    result[NEEDS_STEP_IN_PROPERTY_NAME] = true;
-    return result;
-  }
-  // Function is public.
-  this.RestartFrame = RestartFrame;
-
   // Functions are public for tests.
   this.TestApi = {
     PosTranslator: PosTranslator,

diff --git a/test/mjsunit/debug-liveedit-restart-frame.js b/test/mjsunit/debug-liveedit-restart-frame.js
index d978a9709fb0f7d394b9377d93b65c1fba1109c4..a3182d7bfa55a976899a37e7e360e2d7119e301f 100644 (file)
--- a/test/mjsunit/debug-liveedit-restart-frame.js
+++ b/test/mjsunit/debug-liveedit-restart-frame.js
@@ -97,8 +97,9 @@ function TestCase(test_scenario, expected_output) {
         return;
       }
       var frame = FindCallFrame(exec_state, change_code);
-      // Throws if fails.
-      Debug.LiveEdit.RestartFrame(frame);
+      var error = frame.restart();
+      if (typeof error === 'string')
+          throw new Error(error);
     }
   }