pvrvideosink: Avoid leaking bufferpool configuration
authorSebastian Rasmussen <sebras@hotmail.com>
Sat, 9 Aug 2014 11:24:00 +0000 (13:24 +0200)
committerSebastian Dröge <sebastian@centricular.com>
Mon, 11 Aug 2014 06:49:49 +0000 (08:49 +0200)
gst_buffer_pool_get_config() returns a copy to the bufferpool's
configuration, which must be passed to gst_structure_free() after
use if not given away to gst_buffer_pool_set_config().

Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734537

sys/pvr2d/gstpvrvideosink.c

index 017bec6..7dc30c1 100644 (file)
@@ -994,6 +994,7 @@ gst_pvrvideosink_propose_allocation (GstBaseSink * bsink, GstQuery * query)
     GST_DEBUG_OBJECT (pvrvideosink, "check existing pool caps");
     config = gst_buffer_pool_get_config (pool);
     gst_buffer_pool_config_get (config, &pcaps, &size, NULL, NULL, NULL, NULL);
+    gst_structure_free (config);
 
     if (!gst_caps_is_equal (caps, pcaps)) {
       GST_DEBUG_OBJECT (pvrvideosink, "pool has different caps");