Gengrid : Fix memory leak in elm_gengrid_realized_items_update
authorVBS <vdtizen.sds@samsung.com>
Tue, 3 Feb 2015 23:30:06 +0000 (08:30 +0900)
committerDaniel Juyung Seo <seojuyung2@gmail.com>
Tue, 3 Feb 2015 23:30:07 +0000 (08:30 +0900)
Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
         but elm_gengrid_realized_items_update doesn't free Eina_List.
         So memory leak is happens.
@fix

Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory share increase.

Reviewers: raster, seoz

Differential Revision: https://phab.enlightenment.org/D1903

src/lib/elm_gengrid.c

index f6506f5..3396211 100644 (file)
@@ -4109,11 +4109,11 @@ _elm_gengrid_realized_items_get(Eo *obj EINA_UNUSED, Elm_Gengrid_Data *sd)
 EOLIAN static void
 _elm_gengrid_realized_items_update(Eo *obj, Elm_Gengrid_Data *_pd EINA_UNUSED)
 {
-   Eina_List *list, *l;
+   Eina_List *list;
    Elm_Object_Item *it;
 
    list = elm_gengrid_realized_items_get(obj);
-   EINA_LIST_FOREACH(list, l, it)
+   EINA_LIST_FREE(list, it)
      elm_gengrid_item_update(it);
 }