staging: greybus: codecs: fix type confusion of list iterator variable

If the list does not exit early then data == NULL and 'module' does not
point to a valid list element.
Using 'module' in such a case is not valid and was therefore removed.

Fixes: 6dd67645f22c ("greybus: audio: Use single codec driver registration")
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
Reviewed-by: Mark Greer <mgreer@animalcreek.com>
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220321123626.3068639-1-jakobkoschel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index a446d64..0f50d1e 100644 (file)
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -603,8 +603,8 @@ static int gbcodec_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
                }
        }
        if (!data) {
-               dev_err(dai->dev, "%s:%s DATA connection missing\n",
-                       dai->name, module->name);
+               dev_err(dai->dev, "%s DATA connection missing\n",
+                       dai->name);
                mutex_unlock(&codec->lock);
                return -ENODEV;
        }