scsi: lpfc: Fix verbose logging for SCSI commands issued to SES devices
authorJustin Tee <justin.tee@broadcom.com>
Mon, 17 Apr 2023 19:15:52 +0000 (12:15 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 8 May 2023 11:16:04 +0000 (07:16 -0400)
For SES LUNs with scsi_device sector_size member set to zero, there is no
point to log an LBA.  When verbose FCP driver logging is enabled, sanity
check sector_size before calling scsi_get_lba() on a scsi_cmnd.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20230417191558.83100-2-justintee8345@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_scsi.c

index e989f13..49aa86c 100644 (file)
@@ -4273,7 +4273,8 @@ lpfc_fcp_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
                                 "x%x SNS x%x x%x LBA x%llx Data: x%x x%x\n",
                                 cmd->device->id, cmd->device->lun, cmd,
                                 cmd->result, *lp, *(lp + 3),
-                                (u64)scsi_get_lba(cmd),
+                                (cmd->device->sector_size) ?
+                                (u64)scsi_get_lba(cmd) : 0,
                                 cmd->retries, scsi_get_resid(cmd));
        }