[EFL] Do not check NULL pointer allocated by new.

https://bugs.webkit.org/show_bug.cgi?id=86610

Reviewed by Ryosuke Niwa.

WebKit-Efl doesn't check pointers that are initialized by new.
Those checks are not needed because new operator doesn't return NULL.
Only an overloaded version of new returns NULL pointer.

* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_entry_new):
* ewk/ewk_view.cpp:
(_ewk_view_core_frame_new):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebKit/efl/ChangeLog b/Source/WebKit/efl/ChangeLog
index 4098a7d..487ce02 100644 (file)
--- a/Source/WebKit/efl/ChangeLog
+++ b/Source/WebKit/efl/ChangeLog
@@ -1,3 +1,19 @@
+2012-05-17  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
+
+        [EFL] Do not check NULL pointer allocated by new.
+        https://bugs.webkit.org/show_bug.cgi?id=86610
+
+        Reviewed by Ryosuke Niwa.
+
+        WebKit-Efl doesn't check pointers that are initialized by new.
+        Those checks are not needed because new operator doesn't return NULL.
+        Only an overloaded version of new returns NULL pointer.
+
+        * ewk/ewk_tiled_matrix.cpp:
+        (ewk_tile_matrix_entry_new):
+        * ewk/ewk_view.cpp:
+        (_ewk_view_core_frame_new):
+
 2012-05-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 
         [EFL] fast/frames/frame-crash-with-page-cache.html is crashing

diff --git a/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp b/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp
index 9551a64..a14a1d7 100644 (file)
--- a/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp
+++ b/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp
@@ -265,18 +265,16 @@ void ewk_tile_matrix_entry_new(Ewk_Tile_Matrix* tileMatrix, float zoom)
     EINA_SAFETY_ON_NULL_RETURN(tileMatrix);
 
     Ewk_Tile_Matrix_Entry* entry = new Ewk_Tile_Matrix_Entry;
-    if (entry) {
-        entry->zoom = zoom;
-        entry->count = 0;
-        entry->matrix = eina_matrixsparse_new(1, 1, _ewk_tile_matrix_cell_free, tileMatrix);
-        if (!entry->matrix) {
-            ERR("could not create sparse matrix.");
-            delete entry;
-            return;
-        }
-        tileMatrix->matrices = eina_inlist_prepend(tileMatrix->matrices, EINA_INLIST_GET(entry));
-        tileMatrix->matrix = entry->matrix;
+    entry->zoom = zoom;
+    entry->count = 0;
+    entry->matrix = eina_matrixsparse_new(1, 1, _ewk_tile_matrix_cell_free, tileMatrix);
+    if (!entry->matrix) {
+        ERR("could not create sparse matrix.");
+        delete entry;
+        return;
     }
+    tileMatrix->matrices = eina_inlist_prepend(tileMatrix->matrices, EINA_INLIST_GET(entry));
+    tileMatrix->matrix = entry->matrix;
 }
 
 void ewk_tile_matrix_invalidate(Ewk_Tile_Matrix* tileMatrix)

diff --git a/Source/WebKit/efl/ewk/ewk_view.cpp b/Source/WebKit/efl/ewk/ewk_view.cpp
index 4a9ff8d..7e2ef80 100644 (file)
--- a/Source/WebKit/efl/ewk/ewk_view.cpp
+++ b/Source/WebKit/efl/ewk/ewk_view.cpp
@@ -700,10 +700,6 @@ static void _ewk_view_on_key_up(void* data, Evas*, Evas_Object*, void* eventInfo
 static WTF::PassRefPtr<WebCore::Frame> _ewk_view_core_frame_new(Ewk_View_Smart_Data* smartData, Ewk_View_Private_Data* priv, WebCore::HTMLFrameOwnerElement* owner)
 {
     WebCore::FrameLoaderClientEfl* frameLoaderClient = new WebCore::FrameLoaderClientEfl(smartData->self);
-    if (!frameLoaderClient) {
-        CRITICAL("Could not create frame loader client.");
-        return 0;
-    }
     frameLoaderClient->setCustomUserAgent(String::fromUTF8(priv->settings.userAgent));
 
     return WebCore::Frame::create(priv->page.get(), owner, frameLoaderClient);