h265parse: Fix content light level value changes
authorNicolas Dufresne <nicolas.dufresne@collabora.com>
Tue, 7 Apr 2020 21:04:30 +0000 (17:04 -0400)
committerNicolas Dufresne <nicolas.dufresne@collabora.com>
Wed, 8 Apr 2020 17:58:51 +0000 (13:58 -0400)
The comparision was not testing anything meaninful. This fixes the comparision
so we now update the caps whenever the value differ. This was detected by
coverity.

CID 1461291

gst/videoparsers/gsth265parse.c

index 3aa7364..1477976 100644 (file)
@@ -654,8 +654,8 @@ gst_h265_parse_process_sei (GstH265Parse * h265parse, GstH265NalUnit * nalu)
         if (h265parse->content_light_level_state == GST_H265_PARSE_SEI_EXPIRED) {
           h265parse->update_caps = TRUE;
         } else if (cll.max_content_light_level !=
-            h265parse->content_light_level.max_frame_average_light_level ||
-            cll.max_content_light_level !=
+            h265parse->content_light_level.max_content_light_level ||
+            cll.max_frame_average_light_level !=
             h265parse->content_light_level.max_frame_average_light_level) {
           h265parse->update_caps = TRUE;
         }