[Title] Added some fixes by sonar

[Type]
[Module]
[Priority]
[CQ#]
[Redmine#]
[Problem]
[Cause]
[Solution]
[TestCase]

diff --git a/org.tizen.common.connection/src/org/tizen/common/connection/debugtools/ToolsInstall.java b/org.tizen.common.connection/src/org/tizen/common/connection/debugtools/ToolsInstall.java
index 6a0bff6..fbac890 100755 (executable)
--- a/org.tizen.common.connection/src/org/tizen/common/connection/debugtools/ToolsInstall.java
+++ b/org.tizen.common.connection/src/org/tizen/common/connection/debugtools/ToolsInstall.java
@@ -300,6 +300,7 @@ class InstallProgress implements IRunnableWithProgress {
                 }
             }
         } catch (IOException e1) {
+            Logger.log(e1);
         } finally {
             IOUtil.tryClose(br);
             if ( sdbShell != null ) {

diff --git a/org.tizen.common/src/org/tizen/common/file/EclipseFileHandler.java b/org.tizen.common/src/org/tizen/common/file/EclipseFileHandler.java
index 0b2ca71..49c876b 100755 (executable)
--- a/org.tizen.common/src/org/tizen/common/file/EclipseFileHandler.java
+++ b/org.tizen.common/src/org/tizen/common/file/EclipseFileHandler.java
@@ -187,6 +187,7 @@ extends StandardFileHandler
                        CoreException e
                )
                {
+                       logger.warn( "Exception :{}", e );
                }
                return null;
 

diff --git a/org.tizen.common/src/org/tizen/common/file/VirtualFileHandler.java b/org.tizen.common/src/org/tizen/common/file/VirtualFileHandler.java
index 3fa265e..b3faa2b 100755 (executable)
--- a/org.tizen.common/src/org/tizen/common/file/VirtualFileHandler.java
+++ b/org.tizen.common/src/org/tizen/common/file/VirtualFileHandler.java
@@ -711,6 +711,7 @@ extends AbstractFileHandler
                        file = getFile( path );
                } catch ( Throwable e )
                {
+                       logger.warn( "Exception :{}", e );
                }
                if ( Attribute.TYPE.equals( name ) )
                {
@@ -779,6 +780,7 @@ extends AbstractFileHandler
                        file = getFile( path );
                } catch ( Throwable e )
                {
+                       logger.warn( "Exception :{}", e );
                }
                if ( null != file )
                {

diff --git a/org.tizen.common/src/org/tizen/common/rds/RdsDeltaDetector.java b/org.tizen.common/src/org/tizen/common/rds/RdsDeltaDetector.java
index c890904..e53f274 100644 (file)
--- a/org.tizen.common/src/org/tizen/common/rds/RdsDeltaDetector.java
+++ b/org.tizen.common/src/org/tizen/common/rds/RdsDeltaDetector.java
@@ -47,6 +47,7 @@ import org.eclipse.core.internal.watson.ElementTreeWriter;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.runtime.IPath;
 import org.tizen.common.util.IOUtil;
+import org.tizen.common.util.log.Logger;
 import org.tizen.sdblib.IDevice;
 import org.tizen.sdblib.SyncService;
 
@@ -88,6 +89,7 @@ public class RdsDeltaDetector {
             input = new DataInputStream(new SafeFileInputStream(strLocalFile, strLocalFile + ".temp", TREE_BUFFER_SIZE));
             oldTree = treeReader.readTree(input);
         } catch (IOException e) {
+            Logger.log(e);
         } finally {
             IOUtil.tryClose(input);
         }

diff --git a/org.tizen.common/src/org/tizen/common/rds/ui/preference/PropertyAndPreferencePage.java b/org.tizen.common/src/org/tizen/common/rds/ui/preference/PropertyAndPreferencePage.java
index f72cdbe..c9ad8a3 100644 (file)
--- a/org.tizen.common/src/org/tizen/common/rds/ui/preference/PropertyAndPreferencePage.java
+++ b/org.tizen.common/src/org/tizen/common/rds/ui/preference/PropertyAndPreferencePage.java
@@ -37,6 +37,7 @@ import org.eclipse.ui.IWorkbench;
 import org.eclipse.ui.IWorkbenchPreferencePage;
 import org.eclipse.ui.IWorkbenchPropertyPage;
 import org.eclipse.ui.dialogs.PreferencesUtil;
+import org.tizen.common.util.log.Logger;
 
 //import org.eclipse.jdt.core.IJavaProject;
 //import org.eclipse.jdt.core.JavaCore;
@@ -215,7 +216,7 @@ public abstract class PropertyAndPreferencePage extends PreferencePage implement
                     }
                 }
             } catch (Exception e) {
-                // ignore
+                Logger.log(e);
             }
             ProjectSelectionDialog dialog= new ProjectSelectionDialog(getShell(), projectsWithSpecifics);
             if (dialog.open() == Window.OK) {

diff --git a/org.tizen.common/src/org/tizen/common/ui/view/console/ConsoleProcessClosure.java b/org.tizen.common/src/org/tizen/common/ui/view/console/ConsoleProcessClosure.java
index c82224d..c373aa5 100644 (file)
--- a/org.tizen.common/src/org/tizen/common/ui/view/console/ConsoleProcessClosure.java
+++ b/org.tizen.common/src/org/tizen/common/ui/view/console/ConsoleProcessClosure.java
@@ -85,7 +85,7 @@ public class ConsoleProcessClosure {
                                                fConsole.print(lineSeparator,SWT.NORMAL,AnsicodeAdapter.BLACK);
                                        }
                                } catch (IOException x) {
-                                       // ignore
+                                       x.printStackTrace();
                                } finally {
                                        tryClose( fInputStream );
                                }
@@ -177,7 +177,7 @@ public class ConsoleProcessClosure {
                                fProcess.exitValue();
                                finished = true;
                        } catch (IllegalThreadStateException e) {
-                               //System.err.println("Closure exception " +e);
+                               e.printStackTrace();
                        }
                }
 

diff --git a/org.tizen.common/src/org/tizen/common/util/IOUtil.java b/org.tizen.common/src/org/tizen/common/util/IOUtil.java
index 9fbd2e0..32660b1 100644 (file)
--- a/org.tizen.common/src/org/tizen/common/util/IOUtil.java
+++ b/org.tizen.common/src/org/tizen/common/util/IOUtil.java
@@ -87,6 +87,7 @@ public class IOUtil {
                        }
                        catch ( final IOException e )
                        {
+                               e.printStackTrace();
                        }
                }
        }
@@ -115,6 +116,7 @@ public class IOUtil {
                        }
                        catch ( final IOException e )
                        {
+                               e.printStackTrace();
                        }
                }