projects
/
profile
/
common
/
kernel-common.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8422d1f
)
net/hsr: Fix possible leak in 'hsr_get_node_status()'
author
Geyslan G. Bem
<geyslan@gmail.com>
Thu, 14 Nov 2013 19:12:54 +0000
(16:12 -0300)
committer
David S. Miller
<davem@davemloft.net>
Thu, 14 Nov 2013 22:26:21 +0000
(17:26 -0500)
If 'hsr_get_node_data()' returns error, going directly to 'fail' label
doesn't free the memory pointed by 'skb_out'.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/hsr/hsr_netlink.c
patch
|
blob
|
history
diff --git
a/net/hsr/hsr_netlink.c
b/net/hsr/hsr_netlink.c
index
79d72ca
..
3b9205d
100644
(file)
--- a/
net/hsr/hsr_netlink.c
+++ b/
net/hsr/hsr_netlink.c
@@
-249,7
+249,7
@@
static int hsr_get_node_status(struct sk_buff *skb_in, struct genl_info *info)
&hsr_node_if2_age,
&hsr_node_if2_seq);
if (res < 0)
- goto
fail
;
+ goto
nla_put_failure
;
res = nla_put(skb_out, HSR_A_NODE_ADDR, ETH_ALEN,
nla_data(info->attrs[HSR_A_NODE_ADDR]));