gstplay: Do not error out on message parsing failures

Specially when parsing errors and warnings, the details field can be NULL and
the gst_structure_get() call would return FALSE in such cases, triggering false
positive errors.

Follow-up for #1063

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1869>

diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
index ba1322e..f35a0f1 100644 (file)
--- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
+++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c
@@ -4566,9 +4566,7 @@ gst_play_is_play_message (GstMessage * msg)
     const GstStructure *data = NULL;                                      \
     g_return_if_fail (gst_play_is_play_message (msg));                    \
     data = gst_message_get_structure (msg);                               \
-    if (!gst_structure_get (data, field, value_type, value, NULL)) {      \
-      g_error ("Could not parse field from structure: %s", field);        \
-    }                                                                     \
+    gst_structure_get (data, field, value_type, value, NULL);             \
 } G_STMT_END
 
 /**