Remove useless gtSetFlags calls

For xarch `gtSetFlags` returns true and that makes `genIntToIntCast` use an `and` instruction instead of `mov`/`movzx`. This serves no purpose as no code ever calls `gtRequestSetFlags` on cast nodes nor does `GT_JTRUE` expects a cast node as its operand.

`gtSetFlags` seems to be a leftover from the legacy codegen.

diff --git a/src/jit/codegenxarch.cpp b/src/jit/codegenxarch.cpp
index 746f7af7397f9132a00dd7493b51589d80ff71c5..a2bdb3802adc844bf75094f982a619dd727f1bb6 100755 (executable)
--- a/src/jit/codegenxarch.cpp
+++ b/src/jit/codegenxarch.cpp
@@ -7459,20 +7459,12 @@ void CodeGen::genIntToIntCast(GenTreePtr treeNode)
                 inst_RV_RV(INS_mov, targetReg, sourceReg, srcType);
             }
         }
-        else if  (treeNode->gtSetFlags() && isUnsignedDst && castOp->InReg() && (targetReg == sourceReg))
-        {
-            // if we (might) need to set the flags and the value is in the same register
-            // and we have an unsigned value then use AND instead of MOVZX
-            noway_assert(ins == INS_movzx || ins == INS_mov);
-            ins = INS_AND;
-        }
 
         if (ins == INS_AND)
         {
             noway_assert((needAndAfter == false) && isUnsignedDst);
 
             /* Generate "and reg, MASK */
-            insFlags  flags = treeNode->gtSetFlags() ? INS_FLAGS_SET : INS_FLAGS_DONT_CARE;
             unsigned fillPattern;
             if (size == EA_1BYTE)
                 fillPattern = 0xff;
@@ -7481,7 +7473,7 @@ void CodeGen::genIntToIntCast(GenTreePtr treeNode)
             else
                 fillPattern = 0xffffffff;
 
-            inst_RV_IV(INS_AND, targetReg, fillPattern, EA_4BYTE, flags);
+            inst_RV_IV(INS_AND, targetReg, fillPattern, EA_4BYTE);
         }
 #ifdef _TARGET_AMD64_
         else if (ins == INS_movsxd)
@@ -7516,8 +7508,7 @@ void CodeGen::genIntToIntCast(GenTreePtr treeNode)
             if  (needAndAfter)
             {
                 noway_assert(genTypeSize(dstType) == 2 && ins == INS_movsx);
-                insFlags  flags = treeNode->gtSetFlags() ? INS_FLAGS_SET : INS_FLAGS_DONT_CARE;
-                inst_RV_IV(INS_AND, targetReg, 0xFFFF, EA_4BYTE, flags);
+                inst_RV_IV(INS_AND, targetReg, 0xFFFF, EA_4BYTE);
             }
         }
     }