drm/i915: Remove unwarranted clamping for hsw/bdw
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 18 Apr 2019 20:53:58 +0000 (21:53 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 19 Apr 2019 07:24:09 +0000 (08:24 +0100)
We always start off at an "efficient frequency" and can let the system
autotune from there, eliminating the need to clamp the available range.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190418205358.11450-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_pm.c

index 44be676..87f6fc6 100644 (file)
@@ -8528,18 +8528,9 @@ void intel_init_gt_powersave(struct drm_i915_private *dev_priv)
                gen6_init_rps_frequencies(dev_priv);
 
        /* Derive initial user preferences/limits from the hardware limits */
-       rps->idle_freq = rps->min_freq;
-       rps->cur_freq = rps->idle_freq;
-
        rps->max_freq_softlimit = rps->max_freq;
        rps->min_freq_softlimit = rps->min_freq;
 
-       if (IS_HASWELL(dev_priv) || IS_BROADWELL(dev_priv))
-               rps->min_freq_softlimit =
-                       max_t(int,
-                             rps->efficient_freq,
-                             intel_freq_opcode(dev_priv, 450));
-
        /* After setting max-softlimit, find the overclock max freq */
        if (IS_GEN(dev_priv, 6) ||
            IS_IVYBRIDGE(dev_priv) || IS_HASWELL(dev_priv)) {
@@ -8556,6 +8547,8 @@ void intel_init_gt_powersave(struct drm_i915_private *dev_priv)
 
        /* Finally allow us to boost to max by default */
        rps->boost_freq = rps->max_freq;
+       rps->idle_freq = rps->min_freq;
+       rps->cur_freq = rps->idle_freq;
 
        mutex_unlock(&dev_priv->pcu_lock);
 }