staging: gasket: core: device register debug log cleanups
authorTodd Poynor <toddpoynor@google.com>
Fri, 3 Aug 2018 01:49:50 +0000 (18:49 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Aug 2018 14:12:53 +0000 (16:12 +0200)
At device/driver registration time, convert a not-very-informative
info message to a more informative debug message, drop some not overly
helpful debug messages.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_core.c

index fa477d0..91db71c 100644 (file)
@@ -1735,7 +1735,8 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc)
        int desc_idx = -1;
        struct gasket_internal_desc *internal;
 
-       pr_info("Initializing Gasket framework device\n");
+       pr_debug("Loading %s driver version %s\n", driver_desc->name,
+                driver_desc->driver_version);
        /* Check for duplicates and find a free slot. */
        mutex_lock(&g_mutex);
 
@@ -1764,8 +1765,6 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc)
                return -EBUSY;
        }
 
-       /* Internal structure setup. */
-       pr_debug("Performing initial internal structure setup.\n");
        internal = &g_descs[desc_idx];
        mutex_init(&internal->mutex);
        memset(internal->devs, 0, sizeof(struct gasket_dev *) * GASKET_DEV_MAX);
@@ -1788,7 +1787,6 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc)
         * Not using pci_register_driver() (without underscores), as it
         * depends on KBUILD_MODNAME, and this is a shared file.
         */
-       pr_debug("Registering PCI driver.\n");
        ret = __pci_register_driver(&internal->pci, driver_desc->module,
                                    driver_desc->name);
        if (ret) {
@@ -1796,7 +1794,6 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc)
                goto fail1;
        }
 
-       pr_debug("Registering char driver.\n");
        ret = register_chrdev_region(MKDEV(driver_desc->major,
                                           driver_desc->minor), GASKET_DEV_MAX,
                                     driver_desc->name);