Input: goodix - improve gpiod_get() error logging
authorHans de Goede <hdegoede@redhat.com>
Mon, 13 Dec 2021 04:54:15 +0000 (20:54 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 13 Dec 2021 05:10:18 +0000 (21:10 -0800)
goodix_get_gpio_config() errors are fatal (abort probe()) so log them
at KERN_ERR level rather then as debug messages.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20211212124242.81019-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/goodix.c

index 48362be..148f460 100644 (file)
@@ -954,7 +954,7 @@ retry_get_irq_gpio:
        if (IS_ERR(gpiod)) {
                error = PTR_ERR(gpiod);
                if (error != -EPROBE_DEFER)
-                       dev_dbg(dev, "Failed to get %s GPIO: %d\n",
+                       dev_err(dev, "Failed to get %s GPIO: %d\n",
                                GOODIX_GPIO_INT_NAME, error);
                return error;
        }
@@ -971,7 +971,7 @@ retry_get_irq_gpio:
        if (IS_ERR(gpiod)) {
                error = PTR_ERR(gpiod);
                if (error != -EPROBE_DEFER)
-                       dev_dbg(dev, "Failed to get %s GPIO: %d\n",
+                       dev_err(dev, "Failed to get %s GPIO: %d\n",
                                GOODIX_GPIO_RST_NAME, error);
                return error;
        }