iio: health: afe4404: Make use of the helper function dev_err_probe()
authorCai Huoqing <caihuoqing@baidu.com>
Tue, 28 Sep 2021 01:44:02 +0000 (09:44 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 19 Oct 2021 07:30:44 +0000 (08:30 +0100)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928014403.1563-2-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/health/afe4404.c

index d8a27df..7ef3f5e 100644 (file)
@@ -494,10 +494,10 @@ static int afe4404_probe(struct i2c_client *client,
        }
 
        afe->regulator = devm_regulator_get(afe->dev, "tx_sup");
-       if (IS_ERR(afe->regulator)) {
-               dev_err(afe->dev, "Unable to get regulator\n");
-               return PTR_ERR(afe->regulator);
-       }
+       if (IS_ERR(afe->regulator))
+               return dev_err_probe(afe->dev, PTR_ERR(afe->regulator),
+                                    "Unable to get regulator\n");
+
        ret = regulator_enable(afe->regulator);
        if (ret) {
                dev_err(afe->dev, "Unable to enable regulator\n");