thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs()
authorYangtao Li <frank.li@vivo.com>
Tue, 20 Jun 2023 09:07:22 +0000 (17:07 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 26 Jun 2023 10:03:14 +0000 (12:03 +0200)
Ensure that all error handling branches print error information. In this
way, when this function fails, the upper-layer functions can directly
return an error code without missing debugging information. Otherwise,
the error message will be printed redundantly or missing.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230620090732.50025-1-frank.li@vivo.com
drivers/thermal/thermal_hwmon.c

index fbe55509e3071134493a09b477cb0bf2cf37eda6..c3ae44659b8170fa10a656ede02f5e5407dc0e0f 100644 (file)
@@ -271,11 +271,14 @@ int devm_thermal_add_hwmon_sysfs(struct device *dev, struct thermal_zone_device
 
        ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr),
                           GFP_KERNEL);
-       if (!ptr)
+       if (!ptr) {
+               dev_warn(dev, "Failed to allocate device resource data\n");
                return -ENOMEM;
+       }
 
        ret = thermal_add_hwmon_sysfs(tz);
        if (ret) {
+               dev_warn(dev, "Failed to add hwmon sysfs attributes\n");
                devres_free(ptr);
                return ret;
        }