fpga: Explicitly include correct DT includes
authorRob Herring <robh@kernel.org>
Fri, 14 Jul 2023 17:44:48 +0000 (11:44 -0600)
committerXu Yilun <yilun.xu@intel.com>
Mon, 17 Jul 2023 01:23:04 +0000 (09:23 +0800)
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20230714174449.4055156-1-robh@kernel.org
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
drivers/fpga/altera-fpga2sdram.c
drivers/fpga/altera-freeze-bridge.c
drivers/fpga/altera-pr-ip-core-plat.c
drivers/fpga/microchip-spi.c
drivers/fpga/of-fpga-region.c
drivers/fpga/stratix10-soc.c

index ff3a646..1fa2ccc 100644 (file)
@@ -27,7 +27,7 @@
 #include <linux/kernel.h>
 #include <linux/mfd/syscon.h>
 #include <linux/module.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/regmap.h>
 
 #define ALT_SDR_CTL_FPGAPORTRST_OFST           0x80
index bb6b02e..0c3fb82 100644 (file)
@@ -7,8 +7,9 @@
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/kernel.h>
-#include <linux/of_device.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
+#include <linux/platform_device.h>
 #include <linux/fpga/fpga-bridge.h>
 
 #define FREEZE_CSR_STATUS_OFFSET               0
@@ -198,13 +199,11 @@ static const struct fpga_bridge_ops altera_freeze_br_br_ops = {
        .enable_show = altera_freeze_br_enable_show,
 };
 
-#ifdef CONFIG_OF
 static const struct of_device_id altera_freeze_br_of_match[] = {
        { .compatible = "altr,freeze-bridge-controller", },
        {},
 };
 MODULE_DEVICE_TABLE(of, altera_freeze_br_of_match);
-#endif
 
 static int altera_freeze_br_probe(struct platform_device *pdev)
 {
@@ -268,7 +267,7 @@ static struct platform_driver altera_freeze_br_driver = {
        .remove = altera_freeze_br_remove,
        .driver = {
                .name   = "altera_freeze_br",
-               .of_match_table = of_match_ptr(altera_freeze_br_of_match),
+               .of_match_table = altera_freeze_br_of_match,
        },
 };
 
index 06c6a47..9dc2639 100644 (file)
@@ -9,7 +9,8 @@
  */
 #include <linux/fpga/altera-pr-ip-core.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/mod_devicetable.h>
+#include <linux/platform_device.h>
 
 static int alt_pr_platform_probe(struct platform_device *pdev)
 {
index d6070e7..2a82c72 100644 (file)
@@ -8,7 +8,7 @@
 #include <linux/fpga/fpga-mgr.h>
 #include <linux/iopoll.h>
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/spi/spi.h>
 
 #define        MPF_SPI_ISC_ENABLE      0x0B
index ae82532..a6affd8 100644 (file)
@@ -12,7 +12,9 @@
 #include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/spinlock.h>
 
index f7f0198..cacb9cc 100644 (file)
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 /*
  * FPGA programming requires a higher level of privilege (EL3), per the SoC