ASoC: intel: skylake: Add missing break in skl_tplg_get_token()
authorTakashi Iwai <tiwai@suse.de>
Wed, 3 Oct 2018 17:31:44 +0000 (19:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Nov 2018 19:15:05 +0000 (11:15 -0800)
commit 9c80c5a8831471e0a3e139aad1b0d4c0fdc50b2f upstream.

skl_tplg_get_token() misses a break in the big switch() block for
SKL_TKN_U8_CORE_ID entry.
Spotted nicely by -Wimplicit-fallthrough compiler option.

Fixes: 6277e83292a2 ("ASoC: Intel: Skylake: Parse vendor tokens to build module data")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/intel/skylake/skl-topology.c

index 22f768c..b45c1ae 100644 (file)
@@ -2360,6 +2360,7 @@ static int skl_tplg_get_token(struct device *dev,
 
        case SKL_TKN_U8_CORE_ID:
                mconfig->core_id = tkn_elem->value;
+               break;
 
        case SKL_TKN_U8_MOD_TYPE:
                mconfig->m_type = tkn_elem->value;