drm/bridge: anx7625: fix an error code in anx7625_register_audio()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 24 Nov 2021 14:52:19 +0000 (17:52 +0300)
committerRobert Foss <robert.foss@linaro.org>
Thu, 25 Nov 2021 10:06:38 +0000 (11:06 +0100)
This code accidentally returns IS_ERR(), which is 1, instead of
propagating the negative error code.  The caller doesn't check for
errors so it doesn't affect run time at all.

Fixes: 566fef1226c1 ("drm/bridge: anx7625: add HDMI audio function")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20211124145219.GD13656@kili
drivers/gpu/drm/bridge/analogix/anx7625.c

index 4e94856..2346dbc 100644 (file)
@@ -1636,7 +1636,7 @@ static int anx7625_register_audio(struct device *dev, struct anx7625_data *ctx)
                                                        sizeof(codec_data));
 
        if (IS_ERR(ctx->audio_pdev))
-               return IS_ERR(ctx->audio_pdev);
+               return PTR_ERR(ctx->audio_pdev);
 
        DRM_DEV_DEBUG_DRIVER(dev, "bound to %s", HDMI_CODEC_DRV_NAME);