bfd/

2009-06-27  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/10337
	* elf.c (bfd_section_from_shdr): Don't change sh_link for
	SHT_REL/SHT_RELA sections on executable nor shared library.
	Treat SHT_REL/SHT_RELA sections with sh_link set to SHN_UNDEF
	as a normal section.

ld/testsuite/

2009-06-27  H.J. Lu  <hongjiu.lu@intel.com>

	PR ld/10337
	* ld-ifunc/binutils.exp: New.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 017a740..8708dc9 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,11 @@
+2009-06-27  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR ld/10337
+       * elf.c (bfd_section_from_shdr): Don't change sh_link for
+       SHT_REL/SHT_RELA sections on executable nor shared library.
+       Treat SHT_REL/SHT_RELA sections with sh_link set to SHN_UNDEF
+       as a normal section.
+
 2009-06-25  Nick Clifton  <nickc@redhat.com>
 
        * elf-m10300.c (mn10300_elf_relax_section): Handle non-section

diff --git a/bfd/elf.c b/bfd/elf.c
index e377d68..7f74236 100644 (file)
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -1728,8 +1728,11 @@ bfd_section_from_shdr (bfd *abfd, unsigned int shindex)
           reject them, but, unfortunately, some people need to use
           them.  We scan through the section headers; if we find only
           one suitable symbol table, we clobber the sh_link to point
-          to it.  I hope this doesn't break anything.  */
-       if (elf_elfsections (abfd)[hdr->sh_link]->sh_type != SHT_SYMTAB
+          to it.  I hope this doesn't break anything.
+
+          Don't do it on executable nor shared library.  */
+       if ((abfd->flags & (DYNAMIC | EXEC_P)) == 0
+           && elf_elfsections (abfd)[hdr->sh_link]->sh_type != SHT_SYMTAB
            && elf_elfsections (abfd)[hdr->sh_link]->sh_type != SHT_DYNSYM)
          {
            unsigned int scan;
@@ -1764,8 +1767,10 @@ bfd_section_from_shdr (bfd *abfd, unsigned int shindex)
           represent such a section, so at least for now, we don't
           try.  We just present it as a normal section.  We also
           can't use it as a reloc section if it points to the null
-          section, an invalid section, or another reloc section.  */
+          section, an invalid section, another reloc section, or its
+          sh_link points to the null section.  */
        if (hdr->sh_link != elf_onesymtab (abfd)
+           || hdr->sh_link == SHN_UNDEF
            || hdr->sh_info == SHN_UNDEF
            || hdr->sh_info >= num_sec
            || elf_elfsections (abfd)[hdr->sh_info]->sh_type == SHT_REL

diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index 1119e46..1ff0cdc 100644 (file)
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2009-06-27  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR ld/10337
+       * ld-ifunc/binutils.exp: New.
+
 2009-06-25  Kai Tietz  <kai.tietz@onevision.com>
 
        * ld-pe/aligncomm-1.c (size_t): Add typedef.

diff --git a/ld/testsuite/ld-ifunc/binutils.exp b/ld/testsuite/ld-ifunc/binutils.exp
new file mode 100644 (file)
index 0000000..bd6c953
--- /dev/null
+++ b/ld/testsuite/ld-ifunc/binutils.exp
@@ -0,0 +1,101 @@
+# Expect script for binutils tests
+#   Copyright 2009 Free Software Foundation, Inc.
+#
+# This file is part of the GNU Binutils.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
+# MA 02110-1301, USA.
+#
+# Written by H.J. Lu (hongjiu.lu@intel.com)
+#
+
+# Make sure that binutils can correctly handle ld output in ELF with
+# STT_GNU_IFUNC symbols.
+
+# Run on Linux/x86 only.
+if { !([istarget "i?86-*-elf*"]                
+       || ([istarget "i?86-*-linux*"]
+          && ![istarget "*-*-*aout*"]
+          && ![istarget "*-*-*oldld*"])
+       || [istarget "x86_64-*-linux*"]
+       || [istarget "amd64-*-linux*"]) } {
+    return
+}
+
+proc binutils_test { prog_name ld_options test } {
+    global as
+    global ld
+    global READELF
+    global objcopy
+    global strip
+    global srcdir
+    global subdir
+    global link_output
+
+    eval set prog \$$prog_name
+    set test_name "$prog_name $ld_options ($test)"
+
+    if { ![ld_assemble $as $srcdir/$subdir/$test.s tmpdir/$test.o ] } {
+       unresolved "$test_name"
+       return
+    }
+
+    if { ![ld_simple_link $ld tmpdir/$test "$ld_options tmpdir/$test.o"] } {
+       if { [string match "*not supported*" $link_output]
+            || [string match "*unrecognized option*" $link_output] } {
+           unsupported "$ld_options is not supported by this target"
+       } else {
+           unresolved "$test_name"
+       }
+       return
+    }
+
+    send_log "$READELF -l --wide tmpdir/$test > tmpdir/$test.exp\n"
+    set got [remote_exec host "$READELF -l --wide tmpdir/$test" "" "/dev/null" "tmpdir/$test.exp"]
+    if { [lindex $got 0] != 0 || ![string match "" [lindex $got 1]] } then {
+       send_log "$got\n"
+       unresolved "$test_name"
+       return
+    }
+
+    send_log "$prog tmpdir/$test\n"
+    set got [remote_exec host "$prog tmpdir/$test"]
+    if { [lindex $got 0] != 0 || ![string match "" [lindex $got 1]] } then {
+       send_log "$got\n"
+       fail "$test_name"
+       return
+    }
+
+    send_log "$READELF -l --wide tmpdir/$test > tmpdir/$test.out\n"
+    set got [remote_exec host "$READELF -l --wide tmpdir/$test" "" "/dev/null" "tmpdir/$test.out"]
+    if { [lindex $got 0] != 0 || ![string match "" [lindex $got 1]] } then {
+       send_log "$got\n"
+       unresolved "$test_name"
+       return
+    }
+
+    if { [catch {exec cmp tmpdir/$test.exp tmpdir/$test.out}] } then {
+       send_log "tmpdir/$test.exp tmpdir/$test.out differ.\n"
+       fail "$test_name"
+       return
+    }
+
+    pass "$test_name"
+}
+
+binutils_test strip "" ifunc-4-x86
+binutils_test objcopy "" ifunc-4-x86
+binutils_test strip "" ifunc-4-local-x86
+binutils_test objcopy "" ifunc-4-local-x86