vmware-vga: CVE-2014-3689: turn off hw accel
authorGerd Hoffmann <kraxel@redhat.com>
Mon, 6 Oct 2014 09:42:34 +0000 (11:42 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 28 Oct 2014 09:39:58 +0000 (10:39 +0100)
Quick & easy stopgap for CVE-2014-3689:  We just compile out the
hardware acceleration functions which lack sanity checks.  Thankfully
we have capability bits for them (SVGA_CAP_RECT_COPY and
SVGA_CAP_RECT_FILL), so guests should deal just fine, in theory.

Subsequent patches will add the missing checks and re-enable the
hardware acceleration emulation.

Cc: qemu-stable@nongnu.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Don Koch <dkoch@verizon.com>
hw/display/vmware_vga.c

index 0c36c72..ec63290 100644 (file)
 #include "hw/pci/pci.h"
 
 #undef VERBOSE
+#if 0
 #define HW_RECT_ACCEL
 #define HW_FILL_ACCEL
+#endif
 #define HW_MOUSE_ACCEL
 
 #include "vga_int.h"