Add clock-rate to avoid return EMPTY caps of gst_caps_intersect between offer_caps...

- Refer following FIXME comment of _create_answer_task() in gstwebrtcbin.c:2585
  /* FIXME: technically this is a little overreaching as some fields we
   * we can deal with not having and/or we may have unrecognized fields
   * that we cannot actually support */
- Refer Page 22 of RFC7741, VP8 clock rate MUST be 90000
- now answer can be set transceiver direction after intersection
- VP8 and H264 clock rate must be 90000. In normal case, video caps get this value by pad intersect.
  but, When we use 'recvonly', we don't create video pipeline and use default video caps which had not clock rate.
- In negotiation between answer and offer.
  Before the answer accepts the offer's transceiver, caps are negotiated between the answer and the offer.
  At this time, if the video caps of the answer is EMPTY by gst_caps_intersect(),
  the answer's transceiver is automatically set to 'recvonly'.
  the return value is EMPTY caps of gst_caps_intersect() if clock rate is not set.

[Version] 0.1.117
[Issue Type] Bug fix

Change-Id: I43237638cc74af50067e13dc2668b11ec0931b35
Signed-off-by: Hyunil <hyunil46.park@samsung.com>

diff --git a/include/media_streamer_util.h b/include/media_streamer_util.h
index acdc5f8..b7da60b 100644 (file)
--- a/include/media_streamer_util.h
+++ b/include/media_streamer_util.h
@@ -204,7 +204,7 @@ typedef struct _media_streamer_wl_info_s {
 #define WEBRTC_RTP_TRANSCEIVER_DIRECTION_INACTIVE    "inactive"
 #define WEBRTC_RTP_TRANSCEIVER_DIRECTION_UNKNOWN     "unknown"
 #define DEFAULT_WEBRTC_RTP_TRANSCEIVER_DIRECTION     WEBRTC_RTP_TRANSCEIVER_DIRECTION_UNKNOWN
-#define WEBRTC_DEFAULT_VIDEO_RTP_FORMAT    "application/x-rtp,media=video,encoding-name=VP8,payload=96"
+#define WEBRTC_DEFAULT_VIDEO_RTP_FORMAT    "application/x-rtp,media=video,clock-rate=90000,encoding-name=VP8,payload=96"
 #define WEBRTC_DEFAULT_AUDIO_RTP_FORMAT    "application/x-rtp,media=audio,encoding-name=OPUS,payload=97"
 
 #define MEDIA_STREAMER_DEFAULT_CAMERA_FORMAT "video/x-raw,format=I420,width=352,height=288"

diff --git a/packaging/capi-media-streamer.spec b/packaging/capi-media-streamer.spec
index be53224..3b892bb 100644 (file)
--- a/packaging/capi-media-streamer.spec
+++ b/packaging/capi-media-streamer.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-streamer
 Summary:    A Media Streamer API
-Version:    0.1.116
+Version:    0.1.117
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0