irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONE

There is a huge number of broken device trees out there. Just
grepping through the tree for the use of IRQ_TYPE_NONE in conjunction
with the GIC is scary.

People just don't realise that IRQ_TYPE_NONE just doesn't exist, and
you just get whatever junk was there before. So let's make them aware
of the issue.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 79801c2..ac2e62d 100644 (file)
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1011,6 +1011,9 @@ static int gic_irq_domain_translate(struct irq_domain *d,
                        *hwirq += 16;
 
                *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
+
+               /* Make it clear that broken DTs are... broken */
+               WARN_ON(*type == IRQ_TYPE_NONE);
                return 0;
        }
 
@@ -1020,6 +1023,8 @@ static int gic_irq_domain_translate(struct irq_domain *d,
 
                *hwirq = fwspec->param[0];
                *type = fwspec->param[1];
+
+               WARN_ON(*type == IRQ_TYPE_NONE);
                return 0;
        }