ccconverter: signal cea608 padding as invalid
authorMatthew Waters <matthew@centricular.com>
Tue, 2 Jun 2020 08:07:10 +0000 (18:07 +1000)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Fri, 5 Jun 2020 07:36:22 +0000 (07:36 +0000)
Outputting a valid but null cea608 byte pair may cause some issues with
some checksum packets.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1318>

ext/closedcaption/gstccconverter.c

index a9da170..c363017 100644 (file)
@@ -730,7 +730,7 @@ combine_cc_data (GstCCConverter * self, gboolean pad_cea608,
       cea608_1_i++;
       i++;
     } else if (cea608_1_i < total_cea608_1_count) {
-      out[out_i++] = 0xfc;
+      out[out_i++] = 0xf8;
       out[out_i++] = 0x80;
       out[out_i++] = 0x80;
       cea608_1_i++;
@@ -744,7 +744,7 @@ combine_cc_data (GstCCConverter * self, gboolean pad_cea608,
       cea608_2_i++;
       i++;
     } else if (cea608_2_i < total_cea608_2_count) {
-      out[out_i++] = 0xfd;
+      out[out_i++] = 0xf9;
       out[out_i++] = 0x80;
       out[out_i++] = 0x80;
       cea608_2_i++;