https://bugzilla.gnome.org/show_bug.cgi?id=748184 has resurrected
with commit
3e992d8a
Since gst_vaapi_find_preferred_caps_feature() returns a color format
from caps negotiation, different from the default one (NV12), the
postproc enables the color transformation. But when GL_TEXTURE_UPLOAD
feature is negotiated, no color transformation shall be done.
Nonetheless, with commit
3e992d8a the requested format changes
firstly, because there's no video sink yet, so ANY caps are
negotiated; but later, when there's a video sink and a caps
renegotiation, the GL_TEXTURE_UPLOAD is negotiated though the color
format conversion still ongoing. It is required to reset that
conversion.
This patch force default color format when GL_TEXTURE_UPLOAD is
selected as preferred, thus avoiding the color conversion.
Fixes: #157
/* we don't need to do format conversion if GL_TEXTURE_UPLOAD_META
* is negotiated */
- if (f != GST_VAAPI_CAPS_FEATURE_GL_TEXTURE_UPLOAD_META
- && postproc->format != format)
+ if (f == GST_VAAPI_CAPS_FEATURE_GL_TEXTURE_UPLOAD_META) {
+ postproc->format = DEFAULT_FORMAT;
+ } else if (postproc->format != format) {
postproc->format = format;
+ }
return outcaps;